----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71053/#review216514 -----------------------------------------------------------
Ship it! See my comment in https://reviews.apache.org/r/71050/ - Meng Zhu On July 10, 2019, 5:17 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71053/ > ----------------------------------------------------------- > > (Updated July 10, 2019, 5:17 p.m.) > > > Review request for mesos, Andrei Sekretenko and Meng Zhu. > > > Bugs: MESOS-8789 > https://issues.apache.org/jira/browse/MESOS-8789 > > > Repository: mesos > > > Description > ------- > > This provides helpful information for debugging, as well as for the > webui to display in the roles table. > > > Diffs > ----- > > src/master/readonly_handler.cpp 27965e3290ad9ff09a175b5577d6319e079f0e2d > src/tests/role_tests.cpp 67830bb2654fe2ca334a6bf1dbe37b896143e0e0 > > > Diff: https://reviews.apache.org/r/71053/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
