> On Июль 12, 2019, 5:46 п.п., Andrei Budnik wrote: > > src/slave/containerizer/mesos/isolators/linux/nnp.cpp > > Lines 71 (patched) > > <https://reviews.apache.org/r/70757/diff/7/?file=2154555#file2154555line71> > > > > What happens if a framework explicitly set `no_new_privileges` flag to > > `false` in the `ContainerLaunchInfo`? Does the isolator handle such case? > > James Peach wrote: > In that case, the containerizer would do nothing (i.e. default NNP > status). This would have the same end result, but I agree that it's worth > being explicit here.
At this point, the NNP isolator does not support overriding of a NNP bit by a framework? Here is an example of how `linux/seccomp` isolator handles `seccomp` flag provided by a framework: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/isolators/linux/seccomp.cpp#L98-L103 - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70757/#review216562 ----------------------------------------------------------- On Июль 11, 2019, 11:14 п.п., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70757/ > ----------------------------------------------------------- > > (Updated Июль 11, 2019, 11:14 п.п.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Jie Yu, and James > Peach. > > > Bugs: MESOS-9770 > https://issues.apache.org/jira/browse/MESOS-9770 > > > Repository: mesos > > > Description > ------- > > This patch adds the isolation capability of flipping the > NO_NEW_PRIVILEGES bit for process control. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 2d04f3c182a4274dda527a3da56c894c3c892a12 > src/CMakeLists.txt eb4e2ac699121ac16e2ac58e4606b26aae906ad8 > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/slave/containerizer/mesos/containerizer.cpp > c9a369bcdbfc1676912430c3e84fa567bbd7f766 > src/slave/containerizer/mesos/isolators/linux/nnp.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/linux/nnp.cpp PRE-CREATION > src/slave/containerizer/mesos/launch.cpp > 0419e8e0fbf154396ab5fb5026d77b94cc9fca5b > src/tests/CMakeLists.txt 5eb9c65f30d9d6ade289f9d47b18d73908b1f1db > src/tests/containerizer/linux_nnp_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70757/diff/7/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
