> On Июль 15, 2019, 8:35 д.п., Qian Zhang wrote: > > src/common/future_track.hpp > > Lines 90 (patched) > > <https://reviews.apache.org/r/70887/diff/3/?file=2154659#file2154659line90> > > > > I'd suggest to use `Owned` instead of raw pointer.
I'd prefer to leave `Try` as it's more consistent with similar factory methods `static Try<...> Class::create(...)`. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70887/#review216603 ----------------------------------------------------------- On Июнь 19, 2019, 2:49 п.п., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70887/ > ----------------------------------------------------------- > > (Updated Июнь 19, 2019, 2:49 п.п.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, James Peach, Meng > Zhu, and Qian Zhang. > > > Bugs: MESOS-9837 > https://issues.apache.org/jira/browse/MESOS-9837 > > > Repository: mesos > > > Description > ------- > > This patch introduces a mechanism for tracking pending futures. > This feature allows detection of hanging operations, which get > stuck on a blocking operation or asynchronously. However, this > feature does not provide any mechanism for tracking pending > promises, because `Promise` objects might not be accessible in > various cases. Thereby, we introduce a new class that can be > used to track pending futures, so it might facilitate debugging > of stuck issues. > > > Diffs > ----- > > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/common/future_tracker.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70887/diff/4/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
