----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70888/#review216642 -----------------------------------------------------------
src/slave/constants.hpp Lines 205-207 (patched) <https://reviews.apache.org/r/70888/#comment303844> are you using `COMPONENT_NAME_` prefix because `MESOS_CONTAINERIZER` is already defined in containerizer/mesos/constant.hpp? probably let's figure out what `string component` stand for first. Then, we could better define the constant, and I would probably suggest to have the constant in containerizer/mesos/constant.hpp because we may have docker container stuck issue and if the docker container use this tracker process we need to distinguish two containerizers. src/slave/containerizer/mesos/isolator_tracker.hpp Lines 71 (patched) <https://reviews.apache.org/r/70888/#comment303845> could this be a Owned pointer? - Gilbert Song On June 19, 2019, 7:49 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70888/ > ----------------------------------------------------------- > > (Updated June 19, 2019, 7:49 a.m.) > > > Review request for mesos, Gilbert Song and Qian Zhang. > > > Bugs: MESOS-9839 > https://issues.apache.org/jira/browse/MESOS-9839 > > > Repository: mesos > > > Description > ------- > > This patch adds a new `IsolatorTracker` class that proxies > calls to the real isolator and keeps track of returned futures > by employing `PendingFutureTracker` class. > > > Diffs > ----- > > src/CMakeLists.txt eb4e2ac699121ac16e2ac58e4606b26aae906ad8 > src/Makefile.am 761dde1d63e0f4f1ac4ab86f129f84f3746d3153 > src/slave/constants.hpp cc81e5111e8c3082c940b918230f660a1121a1ac > src/slave/containerizer/mesos/isolator_tracker.hpp PRE-CREATION > src/slave/containerizer/mesos/isolator_tracker.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/70888/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
