> On July 18, 2019, 7:37 a.m., James Peach wrote: > > src/common/kernel_version.hpp > > Lines 17 (patched) > > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line17> > > > > This should be `__KERNEL_VERSION_HPP__` to match the file name.
Ah missed that fixed. > On July 18, 2019, 7:37 a.m., James Peach wrote: > > src/common/kernel_version.hpp > > Lines 24 (patched) > > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line24> > > > > Once you move the function body, you can remove the `using` statements > > and the only remaingin includes should be `try.hpp` and `stout/version.hpp`. Fixed. > On July 18, 2019, 7:37 a.m., James Peach wrote: > > src/common/kernel_version.hpp > > Lines 31 (patched) > > <https://reviews.apache.org/r/71106/diff/1/?file=2155817#file2155817line31> > > > > Can you please move this into `kernel_version.cpp`? Sure - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71106/#review216712 ----------------------------------------------------------- On July 17, 2019, 8:38 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71106/ > ----------------------------------------------------------- > > (Updated July 17, 2019, 8:38 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Moved kernelVersion check to common code. > > > Diffs > ----- > > src/common/kernel_version.hpp PRE-CREATION > src/linux/ns.cpp 2440bb2232dfd9cf57a6cc36aeff874c96297c4b > > > Diff: https://reviews.apache.org/r/71106/diff/1/ > > > Testing > ------- > > > Thanks, > > Jacob Janco > >
