----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71139/ -----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs: MESOS-9668 https://issues.apache.org/jira/browse/MESOS-9668 Repository: mesos Description ------- Currently, the `GET_QUOTA` authorizable action set both `value` and `quota_info` fields. The `value` field is set due to backward compatibility for the `GET_QUOTA_WITH_ROLE` action. This patch makes the `GET_QUOTA` action only set the `value` field with the role name. Since the `quota.QuotaInfo` field is being deprecated, it is no longer set (the local authorizer only looks at the `value` field, it is also probably the case for any external authorizer modules). Also refactored `QuotaHandler::status`. Diffs ----- include/mesos/authorizer/authorizer.proto d09c2341154a39dc74e304742920e01183f0cab1 src/authorizer/local/authorizer.cpp 85821c6b4877e319a2879b26492338b2cd903a6f src/master/master.hpp 5c229c53f96dda6b30731017b8adbf57c9fc9f95 src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125 Diff: https://reviews.apache.org/r/71139/diff/1/ Testing ------- make check Thanks, Meng Zhu