----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71131/#review216802 -----------------------------------------------------------
Ship it! src/tests/allocator.cpp Lines 31-35 (original), 30-34 (patched) <https://reviews.apache.org/r/71131/#comment304025> maybe just use the other one: ``` return createQuota(resources, resources); ``` - Benjamin Mahler On July 19, 2019, 9:32 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71131/ > ----------------------------------------------------------- > > (Updated July 19, 2019, 9:32 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Removed the unnecessary role argument. > And added an overload to specify guarantees and limits differently. > > > Diffs > ----- > > src/tests/allocator.hpp 346b8224d85722b22c9f0df2c60f187fd87173b7 > src/tests/allocator.cpp 2a04fed9cbd34ae7ce4e833741a27db08efc999c > src/tests/hierarchical_allocator_benchmarks.cpp > f3a2c4a3ab45164492e9c260c783dcef52a45e1f > src/tests/hierarchical_allocator_tests.cpp > 9ebeeb6501e909544f5461710059ded66fb70eed > > > Diff: https://reviews.apache.org/r/71131/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >