----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71068/ -----------------------------------------------------------
(Updated July 23, 2019, 1:38 p.m.) Review request for mesos and Benjamin Mahler. Changes ------- Added more comments about the best-effort rescind approach. Bugs: MESOS-9812 https://issues.apache.org/jira/browse/MESOS-9812 Repository: mesos Description ------- Outstanding offers of a role (including offers allocated to its subroles) are rescinded until the sum of its consumed quota and outstanding offered resources are below the requested limits. The rescind logic here, however, overlooks the race between master and the allocator. Namely, there might be pending offers in the master mailbox that have yet to be processed. Here, for simplicity, we ignore this race. To properly handle this, the plan is to move offer management logic into the allocator and rescind offers there. Also added a test. Diffs (updated) ----- src/master/quota_handler.cpp 2a3ca5640c850ec8a8aca7abed45386b5b5e1125 src/tests/master_quota_tests.cpp 8105765172f17f3ea50aa09bc66fede8d21365ab Diff: https://reviews.apache.org/r/71068/diff/5/ Changes: https://reviews.apache.org/r/71068/diff/4-5/ Testing ------- Ran continously without failure. Thanks, Meng Zhu