----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71181/#review216950 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On July 29, 2019, 9:18 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71181/ > ----------------------------------------------------------- > > (Updated July 29, 2019, 9:18 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-9907 > https://issues.apache.org/jira/browse/MESOS-9907 > > > Repository: mesos > > > Description > ------- > > This field might not be present and displayed as NaN in that case. With > this patch the field is unconditionally hidden. > > > Diffs > ----- > > src/webui/app/agents/agent.html 25d233ba5fd7253e04a7c9cf222f7649bab75baf > > > Diff: https://reviews.apache.org/r/71181/diff/1/ > > > Testing > ------- > > * `make check` > * patched agent to not discard `drainConfig` and inspected screen for > `drained` agent w/o `max_grace_period` run via `mesos-local` > > > Thanks, > > Benjamin Bannier > >
