> On Aug. 1, 2019, 10:08 a.m., Chun-Hung Hsiao wrote: > > src/tests/master_tests.cpp > > Lines 9014 (patched) > > <https://reviews.apache.org/r/70831/diff/1/?file=2148567#file2148567line9015> > > > > Alternatively, we can avoid this expectation and do the following: > > ``` > > Future<ResourceProviderID> providerId = resourceProvider->process->id(); > > AWAIT_READY(providerId); > > ``` > > Then s/`resourceProvider->process->info.id()`/`providerId.get()`/ > > > > I'm fine with either approach so please feel free to drop this.
Due to the way I reworked the way the `TestResourceProviderProcess` is used and it not exposing its `info` field anymore, this is actually what I now already do, and this patch does not apply anymore. Dropping this issue and discarding the RR. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70831/#review217026 ----------------------------------------------------------- On June 11, 2019, 2:38 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70831/ > ----------------------------------------------------------- > > (Updated June 11, 2019, 2:38 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > In order for a resource provider to have been assigned and stored an > assigned resource provider ID it needs to receive and process the > corresponding resource provider `SUBSCRIBED` event. > > This patch fixes `MasterTest.UpdateSlaveMessageWithPendingOffers` so we > await the correct event. The test was previously awaiting an > `UpdateSlaveMessage` which is only tangentially related, but does not > guarantee correct event ordering. > > > Diffs > ----- > > src/tests/master_tests.cpp 097f1b77a59e29c6690210773d1556ebf2bb701e > > > Diff: https://reviews.apache.org/r/70831/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
