----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71195/#review217081 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/xfs_quota_tests.cpp Lines 1839 (patched) <https://reviews.apache.org/r/71195/#comment304344> ``` ASSERT_SOME(dirs); ASSERT_FALSE(dirs->empty()) ``` - Andrei Budnik On Авг. 1, 2019, 1:11 д.п., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71195/ > ----------------------------------------------------------- > > (Updated Авг. 1, 2019, 1:11 д.п.) > > > Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-9900 > https://issues.apache.org/jira/browse/MESOS-9900 > > > Repository: mesos > > > Description > ------- > > Parameterize the `disk/xfs` isolator tests on whether we > are enforcing quotas on the sandbox or on the container > rootfs. Separating out the rootfs and sandbox cases wth > parameterization helps to ensure that quota is correctly > applied in both cases and tests don't accidentally pass. > > > Diffs > ----- > > src/tests/containerizer/rootfs.cpp 206cab69f329e714ffb65681be36ba190bf272fe > src/tests/containerizer/xfs_quota_tests.cpp > 96cd40d2fa05664571b04ffe08482c584d2935ba > src/tests/mesos.hpp cd50673f7e4f05539137abda73490d934a9f6dc4 > src/tests/mesos.cpp df363abbfa5717f1748511d7fe155493c35fd17b > > > Diff: https://reviews.apache.org/r/71195/diff/3/ > > > Testing > ------- > > sudo make check (Frdora 30) > > > Thanks, > > James Peach > >
