----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71275/#review217187 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp Lines 5953 (patched) <https://reviews.apache.org/r/71275/#comment304474> Is this necessary? - Greg Mann On Aug. 13, 2019, 9:13 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71275/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2019, 9:13 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, and Greg Mann. > > > Bugs: MESOS-9934 > https://issues.apache.org/jira/browse/MESOS-9934 > > > Repository: mesos > > > Description > ------- > > This logic was missing from the initial implementation of agent > draining. When an agent became unreachable, and then reregistered > with the master, the master would not properly deactivate or drain > the agent. > > This also fixes a potential problem with checking the agent > drain state too early in the case of pending operations. > Operations are not reported to the master until after the agent > reregisters, so agents with the RESOURCE_PROVIDER capability > cannot be considered DRAINED until after the first > UpdateSlaveMessage has arrived. > > > Diffs > ----- > > src/master/master.cpp 31c7c97abecb92591369b417e2ef38a99cc09bac > src/tests/api_tests.cpp c2099674e742eaa08134c5e0a7cdab1734808119 > > > Diff: https://reviews.apache.org/r/71275/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
