----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71297/#review217247 -----------------------------------------------------------
Patch looks great! Reviews applied: [71297] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 16, 2019, 1:57 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71297/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2019, 1:57 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, Joseph Wu, and Till > Toenshoff. > > > Bugs: MESOS-9928 > https://issues.apache.org/jira/browse/MESOS-9928 > > > Repository: mesos > > > Description > ------- > > The FrameworkReconciliationRaceWithUpdateSlave test from the > operation reconciliation tests was flaky since we did not wait > for the scheduler to reconnect before advancing the clock to > trigger reregistration. > > > Diffs > ----- > > src/tests/operation_reconciliation_tests.cpp > 9d084c027ec2f910515cafebf715f7428c43f1a9 > > > Diff: https://reviews.apache.org/r/71297/diff/1/ > > > Testing > ------- > > `./src/mesos-tests > --gtest_filter="*FrameworkReconciliationRaceWithUpdateSlaveMessage*" > --gtest_repeat=200` while simultaneously running `stress-ng` in the > background. > > > Thanks, > > Benno Evers > >