> On Aug. 9, 2019, 9:22 a.m., Chun-Hung Hsiao wrote: > > src/resource_provider/storage/provider.cpp > > Lines 979-995 (patched) > > <https://reviews.apache.org/r/71150/diff/3/?file=2159962#file2159962line1016> > > > > Sorry for not making my suggestion clear enough. I was actually > > thinking about removing `reconcileStoragePools()` and always calling > > `reconcileResources()` even when we only want to reconcile storage pools. > > > > This suggestion makes more sense if we don't reconcile storage pools > > after destroying a MOUNT disk with a stale profile, as I suggested in the > > next patch. But if we want to keep this behavior, then this approach would > > introduce an extra `ListVolumes` call. > > > > If you prefer to avoid having this extra grpc call, then adding this > > extra function seems only give us a little bit of code reuse, and I'm not > > sure if it worths adding an extra function name to the already-long list of > > functions in this class. I'd vote for keeping the code in its original > > place and avoid introducing a function name that doesn't convey its purpose > > clearly.
Updated the code, PTAL. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71150/#review217142 ----------------------------------------------------------- On Aug. 19, 2019, 1:58 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71150/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2019, 1:58 p.m.) > > > Review request for mesos and Chun-Hung Hsiao. > > > Bugs: MESOS-9254 > https://issues.apache.org/jira/browse/MESOS-9254 > > > Repository: mesos > > > Description > ------- > > Factored out storage provider method to update resources. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 6d632606f411d3ca99d3573a57c9f68b02ba8072 > src/tests/storage_local_resource_provider_tests.cpp > 69b59d48ceefebbb7accefe411c54ac5cecff1c3 > > > Diff: https://reviews.apache.org/r/71150/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
