> On Aug. 19, 2019, 12:56 p.m., Benno Evers wrote: > > docs/advanced-contribution.md > > Line 69 (original), 69 (patched) > > <https://reviews.apache.org/r/71299/diff/4/?file=2161403#file2161403line69> > > > > This became a bit ambiguous now, i.e. is only the second step or the > > whole step only required if building from git? > > > > (also, I'm not sure why we have this qualification at all in a > > contributors guide)
I agree, removed the part in parentheses (this seems to have appeared with https://reviews.apache.org/r/36472/ w/o much discussion). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71299/#review217278 ----------------------------------------------------------- On Aug. 20, 2019, 1:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71299/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2019, 1:48 p.m.) > > > Review request for mesos, Benno Evers and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > ------- > > This patch breaks the installation of developer tools (i.e., linter > configuration files and git hooks) out of `./bootstrap`. This not only > simplifies and streamlines the setup, but will allow us to add > developer-only features without breaking users who are just interested > in building a distribution tarball. > > > Diffs > ----- > > bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c > bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 > docs/advanced-contribution.md 573138d3642e901f46ee35db58299627f188b94c > docs/beginner-contribution.md 471f5dd0da30d921cc3b29484d2b02f164f8ca75 > docs/clang-format.md 4289813c2ca78e1b963aa22a596abd6e8aa3a28b > support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b > support/llvm/README.md 188930224ba8ff53dbef8770bc56625be936bb76 > support/setup-dev.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/71299/diff/5/ > > > Testing > ------- > > > Thanks, > > Benjamin Bannier > >
