----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71303/#review217341 -----------------------------------------------------------
Bad review! Reviews applied: [71303, 71301, 71269, 71258, 71257, 71255, 71254] Error: 2019-08-20 23:14:47 URL:https://reviews.apache.org/r/71254/diff/raw/ [5967/5967] -> "71254.patch" [1] error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17 error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17 error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply - Mesos Reviewbot On Aug. 16, 2019, 5 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71303/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2019, 5 p.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-9917 > https://issues.apache.org/jira/browse/MESOS-9917 > > > Repository: mesos > > > Description > ------- > > This paves the way for removing the framework sorters. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 580d35a3b71c1f7e851fa0504c6b9f037c05c378 > src/master/allocator/mesos/sorter/drf/sorter.hpp > 537086039fd804453ea8c682cda775d8fdff038f > src/master/allocator/mesos/sorter/drf/sorter.cpp > 09889cdf3dc8c0e773b8e2e24154fb0edd2cc254 > src/master/allocator/mesos/sorter/random/sorter.hpp > f18b014ed15ff8906fbdbd3248becefde896651c > src/master/allocator/mesos/sorter/random/sorter.cpp > 60a5797472460a8d3d9be938af9f6711ea51d484 > src/master/allocator/mesos/sorter/sorter.hpp > 52b8a7b57bf17759311b32aa56c26e614119b773 > > > Diff: https://reviews.apache.org/r/71303/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
