----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71317/#review217365 -----------------------------------------------------------
src/tests/master_draining_tests.cpp Lines 313-318 (patched) <https://reviews.apache.org/r/71317/#comment304659> Is this used? src/tests/master_draining_tests.cpp Lines 324 (patched) <https://reviews.apache.org/r/71317/#comment304660> Is the agent unreachable? Can we verify that the agent is in the correct state via master API output? Ditto in the second test below. src/tests/master_draining_tests.cpp Lines 357-358 (patched) <https://reviews.apache.org/r/71317/#comment304661> Can we verify that the agent is in the correct drain state via master API output? Here and below. src/tests/master_draining_tests.cpp Lines 713-721 (patched) <https://reviews.apache.org/r/71317/#comment304662> Could you move this expectation down above the agent restart? - Greg Mann On Aug. 19, 2019, 9:58 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71317/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2019, 9:58 p.m.) > > > Review request for mesos, Benno Evers and Greg Mann. > > > Bugs: MESOS-9892 > https://issues.apache.org/jira/browse/MESOS-9892 > > > Repository: mesos > > > Description > ------- > > This exercises the agent draining code when the agent is disconnected > from the master at the time of starting draining. Draining is expected > to proceed once the agent reregisters. > > > Diffs > ----- > > src/tests/master_draining_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71317/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Joseph Wu > >
