----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71203/#review217432 -----------------------------------------------------------
Ship it! support/check-license.py Lines 25-26 (patched) <https://reviews.apache.org/r/71203/#comment304708> Nifty python code :) - Till Toenshoff On Aug. 19, 2019, 7:20 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71203/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2019, 7:20 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > ------- > > This check adds a script which validates that source files have valid > license headers. This will allow us to reuse this functionality with > e.g., the pre-commit tool. > > At the moment the code added here is not invoked from > `support/mesos-style.py` since it will be removed in a follow-up commit. > > > Diffs > ----- > > support/check-license.py PRE-CREATION > > > Diff: https://reviews.apache.org/r/71203/diff/5/ > > > Testing > ------- > > * tested against files with license headers present or absent > * tested against all Python and C++ source files in the repo > > > Thanks, > > Benjamin Bannier > >