----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71204/#review217459 -----------------------------------------------------------
bootstrap.bat Lines 64 (patched) <https://reviews.apache.org/r/71204/#comment304722> s/mlink/mklink/ support/gitlint Lines 18-22 (patched) <https://reviews.apache.org/r/71204/#comment304723> Is there any reason to keep these commented out chunks? support/gitlint Lines 25-30 (patched) <https://reviews.apache.org/r/71204/#comment304724> Consider replacing the comment with a mention of the capital letter rule. i.e. ``` # A commit title must start with a capital letter # and end with a punctuation mark. ``` Also, what do you think about allowing exclamation marks at the end? :) support/gitlint Lines 35-48 (patched) <https://reviews.apache.org/r/71204/#comment304725> Do we need these chunks? - Joseph Wu On Aug. 14, 2019, 4:24 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71204/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2019, 4:24 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-9630 > https://issues.apache.org/jira/browse/MESOS-9630 > > > Repository: mesos > > > Description > ------- > > This patch adds a config for the gitlint tool which is slated to replace > a custom commit-msg hook once we switch our hook infrastructure to the > pre-commit tool. > > > Diffs > ----- > > bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c > bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 > support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b > support/gitlint PRE-CREATION > > > Diff: https://reviews.apache.org/r/71204/diff/7/ > > > Testing > ------- > > n/a > > > Thanks, > > Benjamin Bannier > >
