----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71392/#review217582 -----------------------------------------------------------
support/snapshot.sh Line 36 (original), 34 (patched) <https://reviews.apache.org/r/71392/#comment304858> This is a bit unfortunate I feel as "SNAPSHOT" does not help that much determining the version --- how about we use the HEAD SHA instead? ``` TAG=$VERSION-$SHA ``` support/snapshot.sh Line 56 (original), 53 (patched) <https://reviews.apache.org/r/71392/#comment304855> Why are we hardcoding `-j3` here and below instead of using e.g. `$(nproc)`? - Till Toenshoff On Aug. 28, 2019, 4:39 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71392/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2019, 4:39 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-9955 > https://issues.apache.org/jira/browse/MESOS-9955 > > > Repository: mesos > > > Description > ------- > > Previously the script expected the version to be provided as an > argument. > > > Diffs > ----- > > support/snapshot.sh c30aca02ec999320e2b3f0f3ce36c04aa0425ae3 > > > Diff: https://reviews.apache.org/r/71392/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console > > > Thanks, > > Vinod Kone > >
