----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71393/#review217585 -----------------------------------------------------------
Ship it! Ship It! - Till Toenshoff On Aug. 28, 2019, 4:40 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71393/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2019, 4:40 p.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Bugs: MESOS-9955 > https://issues.apache.org/jira/browse/MESOS-9955 > > > Repository: mesos > > > Description > ------- > > GPG signing is not needed for snapshot JARs (since they are > typically done by CI). But our snapshot building workflow, > i.e., support/snapshot.sh, relies on `make maven-install` which forces > GPG signing to happen. This allows our snapshot script to skip GPG > signing by doing `mvn deploy -Dgpg.skip`. > > Note that GPG signing still happens for RCs and release JARs (which > are typically done by humans) when `mvn deploy` (without `-Dgpg.skip`) > is called (e.g., in support/vote.sh). > > > Diffs > ----- > > src/Makefile.am 5daee632d52e882acc15b90f655a53dab23eaaf6 > > > Diff: https://reviews.apache.org/r/71393/diff/1/ > > > Testing > ------- > > https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Snapshot-Jar-Test/16/console > > > Thanks, > > Vinod Kone > >
