----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71510/ -----------------------------------------------------------
(Updated Sept. 19, 2019, 11:30 a.m.) Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. Changes ------- * Added comment blurbs above the main changes. * Accepted Benjamin's suggested change to mesos-gtest-runner.py. Repository: mesos Description ------- Since the default 'check' target now uses the parallel test runner, there are some changes necessary to use this on Windows. In the script itself, references to RLimits need to be removed, since those structures do not exist on Windows. The TEST_RUNNER variable must include "python" on Windows, since '.py' files are not automatically run with Python on Windows. The script also needs the full test executable name (+ '.exe'). We could omit this previously, because you can run executables while omitting the extension. But the script checks if the file exists, and that operation requires the full name plus extension. Diffs (updated) ----- cmake/MesosConfigure.cmake 83d41addcd2c14358fba8bab2ac654475626a3e8 src/tests/CMakeLists.txt 1e53b396569bf3e2f47199956a630afb6197b992 support/mesos-gtest-runner.py 42c0a143477b5ccd411db482a8877e596f520342 Diff: https://reviews.apache.org/r/71510/diff/2/ Changes: https://reviews.apache.org/r/71510/diff/1-2/ Testing ------- cmake --build . --target check (Windows) Thanks, Joseph Wu
