----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71516/#review217913 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 178-180 (patched) <https://reviews.apache.org/r/71516/#comment305290> "We allow" is rather vague: for example, as currently implemented, the master rescinds offers before removing any roles. Probably it would be better to specifically point to the allocator interface as a cause of this difficulty, like: "This is because the allocator interface allows for a framework role to be removed without recovering resources offered or allocated to this role.' src/master/allocator/mesos/hierarchical.hpp Line 778 (original), 794 (patched) <https://reviews.apache.org/r/71516/#comment305291> newline? src/master/allocator/mesos/hierarchical.cpp Lines 3013 (patched) <https://reviews.apache.org/r/71516/#comment305292> s/no longer subsribe/is no longer subscribed/ or s/subsribe/subscribes/ (still looks a bit weird to my eyes) Not sure whether this comment is needed at all, though - the code below looks clear enough. - Andrei Sekretenko On Sept. 19, 2019, 3:41 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71516/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2019, 3:41 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > A framework is tracked under the role if the framework: > (1) is subscribed to the role; > Or > (2) has resources allocated under the role. > > (2) could be true without (1). This is because we allow > frameworks to update their roles without revoking their > allocated or offered resources. > > This patch recognizes this fact and encapsulates the related > checks in the helper. > > Benchmark result: no major performance impact. > > Master > > BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Added 3000 agents in 90.816373ms > Added 3000 frameworks in 17.202199348secs > Made 3500 allocations in 15.46714944secs > Made 0 allocation in 13.767830924secs > > Master + this patch: > > BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2 > Added 3000 agents in 86.782773ms > Added 3000 frameworks in 18.174924815secs > Made 3500 allocations in 15.813011454secs > Made 0 allocation in 12.882917161secs > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 5ea37912dadded47eaa2d354889c95533b191c59 > src/master/allocator/mesos/hierarchical.cpp > 256fdce61ccfb768605cac1579c9a6632cd26fec > > > Diff: https://reviews.apache.org/r/71516/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
