----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71515/#review217914 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On Sept. 19, 2019, 3:25 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71515/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2019, 3:25 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-9975 > https://issues.apache.org/jira/browse/MESOS-9975 > > > Repository: mesos > > > Description > ------- > > It is possible to update allocations to empty in the sorter. > See MESOS-9015. When this happens, sorter will leak client > entries, since it does not erase the corresponding entries. > > This patch fixes this issue. Also added a regression test. > > > Diffs > ----- > > src/master/allocator/mesos/sorter/drf/sorter.hpp > 2a861e2ea5fb61d20e50efbf3d94ee9757bca592 > src/master/allocator/mesos/sorter/random/sorter.hpp > bc5580959046492cbf6c38fe2cd7a7d9e11c99f4 > src/tests/sorter_tests.cpp 64627c4ea57af19eb00bdff598936e23b55541f5 > > > Diff: https://reviews.apache.org/r/71515/diff/1/ > > > Testing > ------- > > make check > Added test fail on master, pass with the patch > > > Thanks, > > Meng Zhu > >
