----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71690/#review218533 -----------------------------------------------------------
src/common/resources.cpp Line 612 (original) <https://reviews.apache.org/r/71690/#comment306269> Let's keep this line. src/common/resources.cpp Lines 1339 (patched) <https://reviews.apache.org/r/71690/#comment306270> This function has an implicit precondition on `r1` and `r2` referring to identical resource quantities. Let's at least add this to the declarations's documentation. - Benjamin Bannier On Nov. 5, 2019, 6:12 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71690/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2019, 6:12 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-9984 > https://issues.apache.org/jira/browse/MESOS-9984 > > > Repository: mesos > > > Description > ------- > > Added a new function `Resources::getReservationAncestor()` to compute > a common reservation ancestor between two `Resources`. > > > Diffs > ----- > > include/mesos/resources.hpp b8aef28e08f85c87bb78f25a64b0d7318f2727cc > src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24 > src/tests/resources_tests.cpp b5854656b7e9ce7af9e1d8ecad708066512d814f > > > Diff: https://reviews.apache.org/r/71690/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
