----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71748/ -----------------------------------------------------------
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu. Bugs: MESOS-10026 https://issues.apache.org/jira/browse/MESOS-10026 Repository: mesos Description ------- This allows us to jsonify a v0 protobuf directly to a v1 protobuf efficiently, with no need to `evolve()` the message (which is rather expensive). The way this works is by converting all "slave" and "SLAVE" strings in fields and enum values, respectively, to "agent" and "AGENT". Our current v0 to v1 conversion for the v1 operator API simply serializes the v0 message and de-serializes into a v1 message, which means all field tags and message structures are the same, except for field names. The only difference with field names is the use of "agent" in place of "slave". Diffs ----- src/common/http.hpp 062586c0a5a339c7e63c89a3a893ae015d3fd26e src/common/http.cpp b79074f823d3bce2a15736c0ef4739ad13db8d9c Diff: https://reviews.apache.org/r/71748/diff/1/ Testing ------- Added a test in the subsequent patch. Thanks, Benjamin Mahler