-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71750/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko, Greg Mann, and Meng Zhu.
Bugs: MESOS-10026
https://issues.apache.org/jira/browse/MESOS-10026
Repository: mesos
Description
-------
This updates the handling to serialize directly to protobuf or json
from the in-memory v0 state, bypassing expensive intermediate
serialization / de-serialization / object construction / object
destruction.
This initial patch shows the approach that will be used for the
other expensive calls. Note that this type of manual writing is
more brittle and complex, but it can be mostly eliminated if we
keep an up-to-date v1 GetState in memory in the future.
When this approach is applied fully to GetState, it leads to the
following improvement:
Before:
v0 '/state' response took 6.55 secs
v1 'GetState' application/x-protobuf response took 24.08 secs
v1 'GetState' application/json response took 22.76 secs
After:
v0 '/state' response took 8.00 secs
v1 'GetState' application/x-protobuf response took 5.73 secs
v1 'GetState' application/json response took 9.62 secs
Diffs
-----
src/master/http.cpp 60765c9b9d6903f6ed94fa8c614055698caad0da
src/master/master.hpp dc45028d2ecfb61bf9ea82d90d2393af648a6023
Diff: https://reviews.apache.org/r/71750/diff/1/
Testing
-------
make check
Thanks,
Benjamin Mahler
