----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71732/#review218663 -----------------------------------------------------------
Ship it! Ship It! - Benno Evers On Nov. 6, 2019, 12:54 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71732/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2019, 12:54 p.m.) > > > Review request for mesos, Benno Evers and Greg Mann. > > > Repository: mesos > > > Description > ------- > > `Resources::pushReservation` does not mutate the `Resources` it is > invoked on; instead it returns its result which should then be used. > > This issue was identified by making `Resources::pushReservation` > `nodiscard`. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed > > > Diff: https://reviews.apache.org/r/71732/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
