----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71741/#review218721 -----------------------------------------------------------
Fix it, then Ship it! docs/operator-http-api.md Lines 1869 (patched) <https://reviews.apache.org/r/71741/#comment306589> Maybe `s/change/update/`, since we consistently talk about "reservation updates" throughout the patch series? docs/operator-http-api.md Line 1869 (original), 1871 (patched) <https://reviews.apache.org/r/71741/#comment306585> s/reserve/reserves/ docs/operator-http-api.md Line 1870 (original), 1872 (patched) <https://reviews.apache.org/r/71741/#comment306586> Maybe ask a native speaker for a second opinion, but "takes" sounds a bit weird to me. Maybe "accepts parameters"? Also, I would propose adding a short summary of what the call *does* with these parameters, instead of launching straight into backwards compatibility exceptions, something like ``` [...] and the target resources, and updates the reservations of `source` to be equal to the reservations of `target`. ``` docs/operator-http-api.md Lines 1876 (patched) <https://reviews.apache.org/r/71741/#comment306587> Maybe we should also mention here that `source` and `resources` must be identical except for their reservations in this case. docs/operator-http-api.md Lines 1956 (patched) <https://reviews.apache.org/r/71741/#comment306588> Mentioning "multiple levels" here feels a bit like an implementation detail; from a users perspective we simply allow changing one role to another. (also "levels" are not present in this example anyways.) docs/operator-http-api.md Lines 1957 (patched) <https://reviews.apache.org/r/71741/#comment306584> s/fall/for/ - Benno Evers On Nov. 20, 2019, 2:17 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71741/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2019, 2:17 p.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9993 > https://issues.apache.org/jira/browse/MESOS-9993 > > > Repository: mesos > > > Description > ------- > > Updated operator API documention to use rereservation format. > > > Diffs > ----- > > docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c > > > Diff: https://reviews.apache.org/r/71741/diff/2/ > > > Testing > ------- > > Previewed in generated site > > > Thanks, > > Benjamin Bannier > >
