----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71665/#review218881 -----------------------------------------------------------
3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 449 (patched) <https://reviews.apache.org/r/71665/#comment306793> What do you mean "instead of in `accept`"? Aren't we in `accept` right now? 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 460-464 (patched) <https://reviews.apache.org/r/71665/#comment306795> Is it possible to switch `PollSocketImpl::accept()` to use a weak reference instead of adding this code here? 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 502 (patched) <https://reviews.apache.org/r/71665/#comment306796> Nit: remove period at the end of failure message. 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 506 (patched) <https://reviews.apache.org/r/71665/#comment306797> What is the "configure callback"? Could you be more explicit/verbose here? 3rdparty/libprocess/src/ssl/socket_wrapper.cpp Lines 557-558 (patched) <https://reviews.apache.org/r/71665/#comment306798> Why vlog this failure case but not the others? Should we have logging for all these cases, or none? - Greg Mann On Nov. 11, 2019, 7:40 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71665/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2019, 7:40 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10010 > https://issues.apache.org/jira/browse/MESOS-10010 > > > Repository: mesos > > > Description > ------- > > This fills in some of the SSL socket implementation, > in particular the constructor, destructor, connect(), > and accept() methods. > > Much of the setup and verification is taken verbatim from the > libevent socket implementation. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > 48860f8646d388685f0a60ad2a2f613b1f4be61a > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION > 3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/71665/diff/5/ > > > Testing > ------- > > cmake --build . --target libprocess-tests > > Successfully connected to Google :D > With something like this: > ``` > set_environment_variables({ > {"LIBPROCESS_SSL_ENABLED", "true"}, > {"LIBPROCESS_SSL_KEY_FILE", key_path().string()}, > {"LIBPROCESS_SSL_CERT_FILE", certificate_path().string()} > }); > > Try<Socket> client = Socket::create(SocketImpl::Kind::SSL); > ASSERT_SOME(client); > > AWAIT_ASSERT_READY(client->connect( > network::inet::Address(net::IP::parse("216.58.194.206").get(), 443), > openssl::create_tls_client_config(None()))); > ``` > > > Thanks, > > Joseph Wu > >
