----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71862/#review218921 -----------------------------------------------------------
src/master/master.cpp Lines 4739 (patched) <https://reviews.apache.org/r/71862/#comment306843> Hm.. does the following seem better for these? ``` std::move(*actionObjects) ``` That way, we're std::moving the vector directly, as opposed to the Try which at this point we know is Some. - Benjamin Mahler On Dec. 3, 2019, 5:53 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71862/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2019, 5:53 p.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Bugs: MESOS-10023 and MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10023 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > Moved creating authorization Object out of `Master::authorize*Disk`. > > > Diffs > ----- > > src/master/authorization.hpp PRE-CREATION > src/master/authorization.cpp PRE-CREATION > src/master/master.hpp 93630421d58e6fd26566e81a23cd910957795665 > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71862/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
