----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71852/#review218955 -----------------------------------------------------------
Fix it, then Ship it! support/mesos-tidy/entrypoint.sh Line 38 (original), 38 (patched) <https://reviews.apache.org/r/71852/#comment306929> From https://cmake.org/cmake/help/v3.12/release/3.12.html#command-line it sounds like the `--parallel` option still wants a parameter to set the number of cores? If that is not required, maybe you could add a link to the cmake documentation in the commit message? - Benno Evers On Dec. 3, 2019, 1:12 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71852/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2019, 1:12 p.m.) > > > Review request for mesos and Benno Evers. > > > Repository: mesos > > > Description > ------- > > Since the `--parallel` flag for `cmake build` is only supported in more > recent CMake versions we bump the installed version to the latest > release. > > > Diffs > ----- > > support/mesos-tidy/Dockerfile 7d17a82c023c614016e771c305e3a114731eb832 > support/mesos-tidy/entrypoint.sh 7d2225d8f75998ee13acf0bd57c9483dfc7acd98 > > > Diff: https://reviews.apache.org/r/71852/diff/1/ > > > Testing > ------- > > Built a local image and tested it with a modified `support/mesos-tidy.sh`. > > > Thanks, > > Benjamin Bannier > >
