----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71879/#review218973 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/path.hpp Line 154 (original), 154 (patched) <https://reviews.apache.org/r/71879/#comment306962> Ideally we'd still keep a deprecated `absolute()` function around, to not break backwards compatibility. But I'm not sure what our current policy on stout backwards compatibility is, if we're regularly doing similar refactorings in stout, feel free to drop this issue. - Benno Evers On Dec. 5, 2019, 12:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71879/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2019, 12:48 p.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-10062 > https://issues.apache.org/jira/browse/MESOS-10062 > > > Repository: mesos > > > Description > ------- > > Renamed stout's path-related absolute functions to is_absolute. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/longpath.hpp > 499eef30a3d16ac1f6c2e3334ef773e91e987a45 > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > 631babc17fff978b4e2048e5041a9f8db9b282b2 > 3rdparty/stout/include/stout/os/windows/copyfile.hpp > 34723bce9a151582de481d63a865509d4d29c02c > 3rdparty/stout/include/stout/path.hpp > ba1f665ce94b9636d88a7ecce8643c56758f7b5c > 3rdparty/stout/tests/path_tests.cpp > 19dd910a534040468aeb48f15ebdf56dff32bc15 > > > Diff: https://reviews.apache.org/r/71879/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
