> On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 21 (patched) > > <https://reviews.apache.org/r/71882/diff/1/?file=2182174#file2182174line21> > > > > This doesn't seem to be necessary anymore?
This is required for e.g., `CHECK_EQ` (now). > On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 551 (patched) > > <https://reviews.apache.org/r/71882/diff/1/?file=2182174#file2182174line551> > > > > I found the description below easier to parse: > > > > > Relative paths can only be computed between paths which are either > > both absolute or both relative. Fixed. > On Dec. 9, 2019, 1:09 p.m., Benno Evers wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 590 (patched) > > <https://reviews.apache.org/r/71882/diff/1/?file=2182174#file2182174line590> > > > > How about > > > > the range of `base` > > > > the `base` range > > > > the range `[base.begin(), base.end())` > > > > to avoid the awkward backtick-single-quote? Went with your first suggestion. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71882/#review218976 ----------------------------------------------------------- On Dec. 9, 2019, 5:48 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71882/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2019, 5:48 p.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-10062 > https://issues.apache.org/jira/browse/MESOS-10062 > > > Repository: mesos > > > Description > ------- > > Added a stout function to compute relative paths. > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > ba1f665ce94b9636d88a7ecce8643c56758f7b5c > 3rdparty/stout/tests/path_tests.cpp > 19dd910a534040468aeb48f15ebdf56dff32bc15 > > > Diff: https://reviews.apache.org/r/71882/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
