----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71790/#review218992 -----------------------------------------------------------
Patch looks great! Reviews applied: [71659, 71764, 71660, 71661, 71662, 71663, 71664, 71665, 71666, 71790] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Dec. 10, 2019, 3:55 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71790/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2019, 3:55 p.m.) > > > Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till > Toenshoff. > > > Bugs: MESOS-10010 > https://issues.apache.org/jira/browse/MESOS-10010 > > > Repository: mesos > > > Description > ------- > > This implements the SSL socket's sendfile method, which must read > the file (unlike the zero-copy os::sendfile). > > This also moves a test exercising sendfile from process_tests.cpp > into http_tests.cpp and parameterizes it for SSL and non-SSL. > > > Diffs > ----- > > 3rdparty/libprocess/src/ssl/openssl_socket.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > 1433f3d09a72133fab1441be53562d508bc01682 > 3rdparty/libprocess/src/tests/process_tests.cpp > 05dc5ec2fdc74a989689e4378bef775bcf2b7a87 > > > Diff: https://reviews.apache.org/r/71790/diff/3/ > > > Testing > ------- > > cmake --build . --target libprocess-tests > libprocess-tests > > > Thanks, > > Joseph Wu > >
