> On Dec. 4, 2019, 8:27 p.m., Benjamin Mahler wrote: > > src/master/authorization.cpp > > Lines 239-240 (patched) > > <https://reviews.apache.org/r/71864/diff/1/?file=2181790#file2181790line239> > > > > Ditto the broader question about validation errors from the previous > > review. > > Andrei Sekretenko wrote: > As far as I can tell, when authorizing RESERVE/UNRESERVE we have no real > need for the logic "let's authorize for any object if we did not compose any > ActionObject". > > There is an **exception**, though: when there is a mix of reservations > with and without principals in UNRESERVE, it can be argued that this mix is > treated incorrectly (see https://jira.apache.org/jira/browse/MESOS-9562) > This patch implements a solution proposed in that ticket for UNRESERVE.
Should that ticket be linked into this review? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71864/#review218924 ----------------------------------------------------------- On Jan. 3, 2020, 2:12 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71864/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2020, 2:12 p.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Bugs: MESOS-10023 and MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10023 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > NOTE: This patch also partially addresses MESOS-9562 issue > by modifying the logic of authorizing UNRESERVE operations. > Now, if some reservations have no principal, both authorization of > UNRESERVE_RESOURCES for ANY object and authorizations for unreserving > all reservations that have principals will be requested. > > > Diffs > ----- > > src/master/authorization.hpp PRE-CREATION > src/master/authorization.cpp PRE-CREATION > src/master/http.cpp 72587bf054e413402ebf4c6ff8060f7ca8ffcf1b > src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483 > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71864/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
