----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71865/#review219152 -----------------------------------------------------------
Ship it! src/master/authorization.cpp Lines 101 (patched) <https://reviews.apache.org/r/71865/#comment307255> no semi colon? - Benjamin Mahler On Jan. 3, 2020, 2:06 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71865/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2020, 2:06 p.m.) > > > Review request for mesos, Benjamin Bannier and Benjamin Mahler. > > > Bugs: MESOS-10023 and MESOS-10056 > https://issues.apache.org/jira/browse/MESOS-10023 > https://issues.apache.org/jira/browse/MESOS-10056 > > > Repository: mesos > > > Description > ------- > > Moved creating authorization Object out of `Master::authorizeSlave`. > > > Diffs > ----- > > src/master/authorization.hpp PRE-CREATION > src/master/authorization.cpp PRE-CREATION > src/master/master.hpp f97b085ae908278731acd326df68f9f381f09483 > src/master/master.cpp 14b90a5e276df055bb8a570331f27cab200c9869 > > > Diff: https://reviews.apache.org/r/71865/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Andrei Sekretenko > >
