----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/#review219209 -----------------------------------------------------------
Fix it, then Ship it! src/executor/executor.cpp Lines 243 (patched) <https://reviews.apache.org/r/71815/#comment307317> Can you introduce a constant for this `108` and the one below? We should add documentation where this value comes from to that constant. src/tests/command_executor_tests.cpp Lines 511-512 (patched) <https://reviews.apache.org/r/71815/#comment307318> These flags are only present and active later in the chain. If you have time you could reorder the patches so we get a clean bisect, but I don't think that this is critical. - Benjamin Bannier On Jan. 10, 2020, 2:42 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71815/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2020, 2:42 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-10039 > https://issues.apache.org/jira/browse/MESOS-10039 > > > Repository: mesos > > > Description > ------- > > Added support for the `MESOS_DOMAIN_SOCKET` environment variable > to the default executor. If this variable is present, the executor > will use the specified domain socket to connect to the agent, > as opposed to the IP address encoded in the agent PID. > > > Diffs > ----- > > src/executor/executor.cpp dfa58206b65a6827ad4b958879c19a093a672e80 > src/launcher/default_executor.cpp 521494a2770192e39b5159624f057e01f2690c8a > src/tests/command_executor_tests.cpp > c7f7711a7b085bdacd0f16b16a6c85cc47e2045c > src/tests/default_executor_tests.cpp > 49c4e3b37bde848dc7a4fd02a1458c650a84a16f > > > Diff: https://reviews.apache.org/r/71815/diff/4/ > > > Testing > ------- > > Ran the new test. > > > Thanks, > > Benno Evers > >
