----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71977/#review219224 -----------------------------------------------------------
Fix it, then Ship it! src/slave/main.cpp Lines 50 (patched) <https://reviews.apache.org/r/71977/#comment307382> Outdated `todo`? src/slave/main.cpp Lines 653 (patched) <https://reviews.apache.org/r/71977/#comment307383> This can be simplified to `socketFds->size() == 1`. - Benjamin Bannier On Jan. 10, 2020, 2:48 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71977/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2020, 2:48 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Added the ability to specify a unix domain socket > as `systemd:<identifier>` for the `--domain_socket_location` > agent flag. > > This will instruct the agent to expect the domain socket > being passed by systemd with the specified name. > > > Diffs > ----- > > src/slave/flags.cpp 50b09cf3b0cf89568a45afd3fe89fa16c6a79222 > src/slave/main.cpp fd58637cd680291e6794bcdb0655603bb97744c7 > > > Diff: https://reviews.apache.org/r/71977/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
