----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71987/#review219235 -----------------------------------------------------------
Ship it! Ship It! - Benno Evers On Jan. 13, 2020, 10:22 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71987/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2020, 10:22 a.m.) > > > Review request for mesos and Benno Evers. > > > Repository: mesos > > > Description > ------- > > While the interfaces are available on all platforms, currently domain > sockets for executor communication are only available on Linux. This > patch ifdef's the code away on non-Linux platforms; this is consistent > with how we disable tests on non-Linux platforms elsewhere where we > never use a test filter. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 6c71b3c2231d3da77d2fb793cb2bbc38e02cef24 > > > Diff: https://reviews.apache.org/r/71987/diff/1/ > > > Testing > ------- > > `make check` on macos > > > Thanks, > > Benjamin Bannier > >