----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219339 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 607-609 (patched) <https://reviews.apache.org/r/71965/#comment307484> I do not think we should use `rootContainerId` here, instead we should use the first ancestor who has share_cgroups=false. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Line 735 (original), 752-754 (patched) <https://reviews.apache.org/r/71965/#comment307485> Ditto. - Qian Zhang On Jan. 10, 2020, 5:03 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71965/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2020, 5:03 a.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Bugs: MESOS-10076 > https://issues.apache.org/jira/browse/MESOS-10076 > > > Repository: mesos > > > Description > ------- > > This patch adds support for nested cgroups for nested containers. > Nested cgroups are created only for a nested container with explicitly > enabled `share_cgroups` flag. The cgroups isolator stores info about > nested cgroups in the `infos` class variable, which is used to > determine whether a nested container has its nested cgroup. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 4bd3d6dad37dee031660c15e957cc36f63e21fcb > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > b12b73d8e0161d448075378765e77867521de04e > > > Diff: https://reviews.apache.org/r/71965/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
