----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71886/#review219791 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp Lines 124 (patched) <https://reviews.apache.org/r/71886/#comment308011> Maybe store this value to reuse it here and below? ``` const double& effectiveLimit = cpuLimit.isSome() ? cpuLimit.get() : cpuRequest; ``` - Greg Mann On Feb. 26, 2020, 12:12 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71886/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2020, 12:12 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10047 > https://issues.apache.org/jira/browse/MESOS-10047 > > > Repository: mesos > > > Description > ------- > > Set container's `cpu.cfs_quota_us` to its CPU resource limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/cpu.cpp > 960bd141430387e076a8fab1948d07719613ed90 > > > Diff: https://reviews.apache.org/r/71886/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
