----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72202/#review219808 -----------------------------------------------------------
Patch looks great! Reviews applied: [72201, 72202] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On March 5, 2020, 11:11 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72202/ > ----------------------------------------------------------- > > (Updated March 5, 2020, 11:11 p.m.) > > > Review request for mesos, Andrei Sekretenko, Greg Mann, and Joseph Wu. > > > Bugs: MESOS-10100 > https://issues.apache.org/jira/browse/MESOS-10100 > > > Repository: mesos > > > Description > ------- > > This test uses only linux style paths and fails on windows. This > happened because this code was introduced recently but there was > no testing or CI running on windows to catch it. > > > Diffs > ----- > > 3rdparty/stout/tests/path_tests.cpp > d418d1b53886042400365d32f7999e84059911c3 > > > Diff: https://reviews.apache.org/r/72202/diff/1/ > > > Testing > ------- > > Ran through a windows CI. > > > Thanks, > > Benjamin Mahler > >
