----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/#review219881 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 191 (patched) <https://reviews.apache.org/r/71858/#comment308124> Could you add a comment here explaining this helper? - Greg Mann On March 9, 2020, 2:04 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71858/ > ----------------------------------------------------------- > > (Updated March 9, 2020, 2:04 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10046 > https://issues.apache.org/jira/browse/MESOS-10046 > > > Repository: mesos > > > Description > ------- > > Set resource limits when launching executor container. > > > Diffs > ----- > > src/slave/slave.hpp 03279db082bdba23dbfeb2d93081a908e609aec2 > src/slave/slave.cpp a914de4bae5630126ae26b9e7dee8c8784ce1ee0 > > > Diff: https://reviews.apache.org/r/71858/diff/11/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
