----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219915 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp Lines 415-416 (original), 423-425 (patched) <https://reviews.apache.org/r/71965/#comment308154> If there are already a top-level container and a 1st level nested container (`share_cgroup==false`) running, now a 2nd level nested container (`share_cgroup==true`) with resource requests/limits specified is launched, I think here we need to increase the resource limits of the 1st level nested cgroup to ensure it includes the 2nd level nested container's resources. Similarly when that 2nd level nested container terminates, we should decrease the 1st level nested cgroup's limits. Or in MVP, we can just disallow launching 2nd level nested container with resource requests/limits specified? I.e., if executor wants to launch a 2nd level nested container, that container's `share_cgroups` can only be true and it can not have resource requests/limits specified. - Qian Zhang On Feb. 14, 2020, 1:19 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71965/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2020, 1:19 a.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Bugs: MESOS-10076 > https://issues.apache.org/jira/browse/MESOS-10076 > > > Repository: mesos > > > Description > ------- > > This patch adds support for nested cgroups for nested containers. > Nested cgroups are created only for a nested container with explicitly > disabled `share_cgroups` flag. The cgroups isolator stores info about > nested cgroups in the `infos` class variable, which is used to > determine whether a nested container has its nested cgroup. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > 4bd3d6dad37dee031660c15e957cc36f63e21fcb > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > b12b73d8e0161d448075378765e77867521de04e > > > Diff: https://reviews.apache.org/r/71965/diff/5/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
