----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72189/#review219918 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On March 4, 2020, 6:56 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72189/ > ----------------------------------------------------------- > > (Updated March 4, 2020, 6:56 p.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Parametrized some `NestedMesosContainerizerTest` tests on whether we > are launching nested containers with `shared_cgroups=false` or not. > Previously, all nested containers shared cgroups with their parent by > default. Now, since we've added support for nested containers with > their own cgroups, we need to verify that a nested container with > `shared_cgroups=false` can be successfully launched and it does not > lead to errors during the recovery of Mesos containerizer. > > > Diffs > ----- > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > c6f96e6b1bc0d9989ca87d23e112604820ac1d51 > > > Diff: https://reviews.apache.org/r/72189/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
