> On March 11, 2020, 4:34 p.m., Greg Mann wrote: > > Could you update the description of this patch with a note that not all > > callsites of `Containerizer::update` are updated here, since some involve > > significant related code changes? In particular, I noticed that a couple > > callsites are updated in https://reviews.apache.org/r/71952/, but it > > doesn't seem desirable to merge these two patches together.
Actually the purpose of this patch is to update the signature of `Containerizer::update` by adding a `resourceLimits` parameter rather than updating the callsites of `Containerizer::update` which is purpose of https://reviews.apache.org/r/71952/ . - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219883 ----------------------------------------------------------- On March 4, 2020, 9:43 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71950/ > ----------------------------------------------------------- > > (Updated March 4, 2020, 9:43 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10050 > https://issues.apache.org/jira/browse/MESOS-10050 > > > Repository: mesos > > > Description > ------- > > Updated containerizer's `update()` method to handle resource limits. > > > Diffs > ----- > > src/slave/containerizer/composing.hpp > 0f838fa63b02d38606a6c484f01d24952d569721 > src/slave/containerizer/composing.cpp > d854794fc4775fb8a05efc233d488a64b9ef620a > src/slave/containerizer/containerizer.hpp > 6a9ebed5e55ad1cfed6340479743ef2bb4c05dab > src/slave/containerizer/docker.hpp 0349f537cef9651427e0e3ed33fd693107e07aa0 > src/slave/containerizer/docker.cpp 2a9b2ffcbd01ae916839ae43c8342285ac3e14a2 > src/slave/containerizer/mesos/containerizer.hpp > 9e86ff43535c4be937baa238442e8f0db8857a27 > src/slave/containerizer/mesos/containerizer.cpp > d034c02c0f73a2745a063561430a1bce7b552420 > src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276 > src/tests/containerizer.cpp 3ac992f8599e8a48f428b506f5bdecc722050c6a > src/tests/containerizer/docker_containerizer_tests.cpp > 689a7220a09f2a58dffdf0dc9fd9f0548600be0e > src/tests/containerizer/mock_containerizer.hpp > 8700257a9347199ed6e32b8b6b2a58787d68af03 > src/tests/master_draining_tests.cpp > a91201e0bfb6f53f70dbdc4649cc344076ef474b > src/tests/master_tests.cpp d0f53b2139bf36ff15a27e438f058f4914df5caa > src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75 > src/tests/registrar_zookeeper_tests.cpp > 9d3ea5f194374fb3492fdfa8bd2efeef55fc4743 > src/tests/scheduler_tests.cpp 299d3a06ca1fd55ef55dc9be323b98a4da3be31a > src/tests/slave_tests.cpp 92fa2996f0e39dded79aa372ddf2390b68b885a2 > > > Diff: https://reviews.apache.org/r/71950/diff/3/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
