----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72250/#review220032 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto Lines 3362-3363 (original), 3362-3363 (patched) <https://reviews.apache.org/r/72250/#comment308296> I think we do not need to mention `Resource requests and limits cannot be specified for such containers.` because there are not resource requests and limits fields in the `LaunchNestedContainerSession` protobuf message. include/mesos/mesos.proto Lines 3364-3365 (original), 3364-3365 (patched) <https://reviews.apache.org/r/72250/#comment308297> Ditto, there is not resource limits field in the `ExecutorInfo` protobuf message. - Qian Zhang On March 19, 2020, 10:05 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72250/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 10:05 p.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Updated the comment for the 'share_cgroups' field. > > > Diffs > ----- > > include/mesos/mesos.proto 40c45de371b12d84aeebcc91847336c4968592f2 > include/mesos/v1/mesos.proto 638763612ccb302f052eb30caf661984087314e1 > > > Diff: https://reviews.apache.org/r/72250/diff/1/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
