> On April 22, 2020, 1:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > <https://reviews.apache.org/r/72409/diff/1/?file=2224549#file2224549line30> > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor ID for a task? > > Greg Mann wrote: > In the LAUNCH_GROUP call, one or more tasks is specified along with an > executor info, so there is always an executor ID specified. > > Greg Mann wrote: > I updated the text to hopefully make this a little clearer, let me know > what you think. > > Qian Zhang wrote: > I see the updated text is: > > When one task is specified with an executor that has a unique executor > ID > > But IIUC, for the `LAUNCH_GROUP` call, the executor is not specified to > the individual task (i.e., `TaskInfo.executor`) in the task group, instead it > is specified in the `LaunchGroup` protobuf message, right? > ``` > message LaunchGroup { > required ExecutorInfo executor = 1; > required TaskGroupInfo task_group = 2; > } > ```
Yes, I think the language "one task is specified with an executor" makes sense in that context. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72409/#review220420 ----------------------------------------------------------- On April 27, 2020, 11:57 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72409/ > ----------------------------------------------------------- > > (Updated April 27, 2020, 11:57 p.m.) > > > Review request for mesos, Andrei Budnik, Benjamin Mahler, Qian Zhang, and Tim > Harper. > > > Bugs: MESOS-10115 > https://issues.apache.org/jira/browse/MESOS-10115 > > > Repository: mesos > > > Description > ------- > > This adds a new document containing an introduction for > scheduler authors to the available methods for running > workloads in a Mesos cluster. > > > Diffs > ----- > > docs/home.md 027319fa28abbdac21588ad1c62dae588033f60e > docs/running-workloads.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/72409/diff/2/ > > > Testing > ------- > > Viewed with `site/mesos-website-dev.sh` > > > Thanks, > > Greg Mann > >