----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72716/#review221452 -----------------------------------------------------------
src/slave/csi_server.cpp Lines 294 (patched) <https://reviews.apache.org/r/72716/#comment310473> Could you please add a comment clarifying why we overwrite (re-assign) `startupComplete` here? src/slave/csi_server.cpp Lines 333 (patched) <https://reviews.apache.org/r/72716/#comment310471> Why does this lambda capture `pluginName` and `volumeId` (of type "const reference to...") by reference? Can these arguments be allocated on the stack? - Andrei Budnik On Авг. 3, 2020, 6:58 п.п., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72716/ > ----------------------------------------------------------- > > (Updated Авг. 3, 2020, 6:58 п.п.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > Added implementation of the CSI server. > > > Diffs > ----- > > src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/slave/csi_server.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/72716/diff/4/ > > > Testing > ------- > > Details at the end of this chain. > > > Thanks, > > Greg Mann > >